View Issue Details

IDProjectCategoryView StatusLast Update
0006735JEDI Code Library02 Installationpublic2024-01-02 19:57
ReporteredboredAssigned ToAHUser 
PrioritynormalSeverityblockReproducibilityalways
Status resolvedResolutionduplicate 
Product VersionVersion 2.5 (Subversion repository/Daily zips) 
Target VersionFixed in VersionVersion 2.5 (Subversion repository/Daily zips) 
Summary0006735: Delphi 7 install crashes on jclSysInfo inline and deprecated issues
DescriptionLatest jclSysInfo.pas is missing {$IFDEF SUPPORTS_DEPRECATED} , {$IFDEF SUPPORTS_DEPRECATED_DETAILS}, and {$IFDEF SUPPORTS_DEPRECATED} compiler directives on a number of functions.
Steps To ReproduceTry to install in Delphi 7
Additional InformationFixed and attached diff/patch file.
TagsDelphi 7.0
Fixed in GIT commit
Fixed in SVN revision
IDE version7

Relationships

duplicate of 0006733 resolvedAHUser Module doesn't compile under Delphi 7 

Activities

edbored

2021-12-29 23:12

reporter  

jclSysInfoFix.diff (4,319 bytes)
Index: JclSysInfo.pas
===================================================================
--- JclSysInfo.pas	(revision 9861)
+++ JclSysInfo.pas	(working copy)
@@ -344,14 +344,14 @@
 function GetWindowsReleaseCode: String;
 function GetWindowsReleaseCodeName: String;
 function GetWindowsReleaseVersion: String;
-function GetWindows10DisplayVersion: string; deprecated 'Use GetWindowsDisplayVersion';
-function GetWindows10ReleaseId: Integer; deprecated 'Use GetWindowsReleaseId';
-function GetWindows10ReleaseName: String; deprecated 'Use GetWindowsReleaseName';
-function GetWindows10ReleaseCodeName: String; deprecated 'Use GetWindowsReleaseCodeName';
-function GetWindows10ReleaseVersion: String; deprecated 'Use GetWindowsReleaseVersion';
-function GetWindowsServerDisplayVersion: string; deprecated 'Use GetWindowsDisplayVersion';
-function GetWindowsServerReleaseId: Integer; deprecated 'Use GetWindowsReleaseId';
-function GetWindowsServerReleaseVersion: String; deprecated 'Use GetWindowsReleaseVersion';
+function GetWindows10DisplayVersion: string; {$IFDEF SUPPORTS_DEPRECATED} deprecated  {$IFDEF SUPPORTS_DEPRECATED_DETAILS} 'Use GetWindowsDisplayVersion' {$ENDIF} {$ENDIF};
+function GetWindows10ReleaseId: Integer; {$IFDEF SUPPORTS_DEPRECATED} deprecated  {$IFDEF SUPPORTS_DEPRECATED_DETAILS} 'Use GetWindowsReleaseId' {$ENDIF} {$ENDIF};
+function GetWindows10ReleaseName: String; {$IFDEF SUPPORTS_DEPRECATED} deprecated  {$IFDEF SUPPORTS_DEPRECATED_DETAILS} 'Use GetWindowsReleaseName' {$ENDIF} {$ENDIF};
+function GetWindows10ReleaseCodeName: String; {$IFDEF SUPPORTS_DEPRECATED} deprecated  {$IFDEF SUPPORTS_DEPRECATED_DETAILS} 'Use GetWindowsReleaseCodeName' {$ENDIF} {$ENDIF};
+function GetWindows10ReleaseVersion: String; {$IFDEF SUPPORTS_DEPRECATED} deprecated  {$IFDEF SUPPORTS_DEPRECATED_DETAILS} 'Use GetWindowsReleaseVersion' {$ENDIF} {$ENDIF};
+function GetWindowsServerDisplayVersion: string; {$IFDEF SUPPORTS_DEPRECATED} deprecated {$IFDEF SUPPORTS_DEPRECATED_DETAILS} 'Use GetWindowsDisplayVersion' {$ENDIF} {$ENDIF};
+function GetWindowsServerReleaseId: Integer; {$IFDEF SUPPORTS_DEPRECATED} deprecated  {$IFDEF SUPPORTS_DEPRECATED_DETAILS} 'Use GetWindowsReleaseId' {$ENDIF} {$ENDIF};
+function GetWindowsServerReleaseVersion: String; {$IFDEF SUPPORTS_DEPRECATED} deprecated  {$IFDEF SUPPORTS_DEPRECATED_DETAILS} 'Use GetWindowsReleaseVersion' {$ENDIF} {$ENDIF};
 function GetOpenGLVersion(const Win: THandle; out Version, Vendor: AnsiString): Boolean;
 function GetNativeSystemInfo(var SystemInfo: TSystemInfo): Boolean;
 function GetProcessorArchitecture: TProcessorArchitecture;
@@ -1543,22 +1543,22 @@
     Result := RegReadIntegerDef(HKEY_LOCAL_MACHINE, Key, Name, Def);
 end;
 
-function ReadWindowsCurrentVersionStringValue(const Name: string; Def: string; ForceNative: boolean = false): string; inline;
+function ReadWindowsCurrentVersionStringValue(const Name: string; Def: string; ForceNative: boolean = false): string; {$IFDEF SUPPORTS_INLINE} inline; {$ENDIF}
 begin
   Result := RegReadHklmKeyStringValue(HKLM_CURRENT_VERSION_WINDOWS, Name, Def, ForceNative);
 end;
 
-function ReadWindowsCurrentVersionIntegerValue(const Name: string; Def: Integer; ForceNative: boolean = false): Integer; inline;
+function ReadWindowsCurrentVersionIntegerValue(const Name: string; Def: Integer; ForceNative: boolean = false): Integer; {$IFDEF SUPPORTS_INLINE} inline; {$ENDIF}
 begin
   Result := RegReadHklmKeyIntegerValue(HKLM_CURRENT_VERSION_WINDOWS, Name, Def, ForceNative);
 end;
 
-function ReadWindowsNTCurrentVersionStringValue(const Name: string; Def: string; ForceNative: boolean = false): string; inline;
+function ReadWindowsNTCurrentVersionStringValue(const Name: string; Def: string; ForceNative: boolean = false): string; {$IFDEF SUPPORTS_INLINE} inline; {$ENDIF}
 begin
   Result := RegReadHklmKeyStringValue(HKLM_CURRENT_VERSION_NT, Name, Def, ForceNative);
 end;
 
-function ReadWindowsNTCurrentVersionIntegerValue(const Name: string; Def: Integer; ForceNative: boolean = false): Integer; inline;
+function ReadWindowsNTCurrentVersionIntegerValue(const Name: string; Def: Integer; ForceNative: boolean = false): Integer; {$IFDEF SUPPORTS_INLINE} inline; {$ENDIF}
 begin
   Result := RegReadHklmKeyIntegerValue(HKLM_CURRENT_VERSION_NT, Name, Def, ForceNative);
 end;
jclSysInfoFix.diff (4,319 bytes)

edbored

2021-12-29 23:15

reporter   ~0022017

Just noticed this is a duplicate of 0006733

AHUser

2024-01-02 19:57

developer   ~0022068

Already fixed in git main branch

Issue History

Date Modified Username Field Change
2021-12-29 23:12 edbored New Issue
2021-12-29 23:12 edbored Tag Attached: Delphi 7.0
2021-12-29 23:12 edbored File Added: jclSysInfoFix.diff
2021-12-29 23:15 edbored Note Added: 0022017
2024-01-02 19:57 AHUser Relationship added duplicate of 0006733
2024-01-02 19:57 AHUser Assigned To => AHUser
2024-01-02 19:57 AHUser Status new => resolved
2024-01-02 19:57 AHUser Resolution open => duplicate
2024-01-02 19:57 AHUser Fixed in Version => Version 2.5 (Subversion repository/Daily zips)
2024-01-02 19:57 AHUser Note Added: 0022068